Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: RP error handling #514

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: RP error handling #514

merged 1 commit into from
Feb 18, 2025

Conversation

walkah
Copy link
Collaborator

@walkah walkah commented Feb 16, 2025

Summary

This pull request makes the following changes to help resource provider reliability:

  • Change when we run ensureResourceOffers to run after every runJob (whether it succeeds or fails)
  • Catches non-"completed" terminal bacalhau execution states (failed and stopped) to properly exit the execution loop

@walkah walkah requested a review from a team as a code owner February 16, 2025 22:00
@cla-bot cla-bot bot added the cla-signed label Feb 16, 2025
@github-actions github-actions bot added the fix label Feb 16, 2025
narbs91
narbs91 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@narbs91 narbs91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@walkah walkah merged commit cd39bfc into main Feb 18, 2025
5 checks passed
@walkah walkah deleted the walkah/fix-rp-error-handling branch February 18, 2025 19:44
@lilypad-releases lilypad-releases bot mentioned this pull request Feb 18, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@narbs91 narbs91 narbs91 approved these changes

Assignees
No one assigned
Labels
cla-signed fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walkah @narbs91