ci: check code style with clang-format

Author: Zijian Zhang

.github/workflows/build_docs.yml

@@ -1,5 +1,11 @@
 on:
   push:
+    paths:
+      - .github/workflows/build_docs.yml
+      - docs/**
+      - src/**/*.h
+      - Doxyfile
+      - DoxygenLayout.xml
   workflow_dispatch:
 
 jobs:

.github/workflows/build_levilamina.yml

@@ -155,16 +155,13 @@ jobs:
             build/windows/x64/debug/LeviLamina.pdb
 
   check-style:
-    runs-on: ubuntu-latest
+    runs-on: windows-latest
     steps:
       - uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 18
-
       - run: |
-          npm install clang-format@1.8.0
+          choco install llvm -y --version=17.0.6
 
       - run: |
-          npx clang-format --dry-run --Werror $(find src/ -type f -name '*.cpp' -o -name '*.h')
+          Get-ChildItem src/ -Filter *.cpp -Recurse | ForEach-Object { clang-format -i -Werror $_.FullName }
+          Get-ChildItem src/ -Filter *.h -Recurse | ForEach-Object { clang-format -i -Werror $_.FullName }

src/ll/api/memory/PatchHelper.h

@@ -51,11 +51,11 @@ namespace ll::utils {
 
 template <size_t len>
 struct PatchHelper {
-    uchar               data[len];
+    uchar data[len];
     using ref_t = uchar (&)[len];
-    constexpr bool      operator==(ref_t ref) const noexcept { return memcmp(data, ref, sizeof data) == 0; }
-    constexpr bool      operator!=(ref_t ref) const noexcept { return memcmp(data, ref, sizeof data) != 0; }
-    constexpr bool      operator==(PatchHelper const& ref) const noexcept {
+    constexpr bool operator==(ref_t ref) const noexcept { return memcmp(data, ref, sizeof data) == 0; }
+    constexpr bool operator!=(ref_t ref) const noexcept { return memcmp(data, ref, sizeof data) != 0; }
+    constexpr bool operator==(PatchHelper const& ref) const noexcept {
         return memcmp(data, ref.data, sizeof data) == 0;
     }
     constexpr bool operator!=(PatchHelper const& ref) const noexcept {

src/mc/common/wrapper/optional_ref.h

@@ -104,7 +104,7 @@ class optional_ref {
         return std::invoke(*mPtr, static_cast<Types&&>(args)...);
     }
     template <class Arg>
-    [[nodiscard]] constexpr decltype(auto) operator[](Arg && index) const {
+    [[nodiscard]] constexpr decltype(auto) operator[](Arg&& index) const {
         return get()[std::forward<Arg>(index)];
     }
     [[nodiscard]] constexpr decltype(auto) end() { return get().end(); }

src/mc/deps/core/common/bedrock/MemoryPage.h

@@ -35,7 +35,7 @@ class MemoryPage {
     // symbol: ?_allocate@MemoryPage@JSONObject@Bedrock@@AEAAPEAXP8123@EAA_K_K0@ZP8123@EAAPEAX00@Z00@Z
     MCAPI void* _allocate(
         uint64 (Bedrock::JSONObject::MemoryPage::*)(uint64, uint64),
-        void*  (Bedrock::JSONObject::MemoryPage::*)(uint64, uint64),
+        void* (Bedrock::JSONObject::MemoryPage::*)(uint64, uint64),
         uint64,
         uint64
     );

src/mc/deps/core/utility/Util.h

@@ -226,7 +226,7 @@ MCAPI std::vector<std::string> splitLines(
     std::vector<std::string> const& delims,
     bool                            includeDelimCharsInResult,
     bool                            includeEmptyLines,
-    std::istream&                   (*fnGetline)(std::istream&, std::string&)
+    std::istream& (*fnGetline)(std::istream&, std::string&)
 );
 
 // symbol:

src/mc/deps/raknet/RakPeer.h

@@ -427,7 +427,7 @@ class RakPeer : public RakPeerInterface {
 
     // symbol: ?SetUserUpdateThread@RakPeer@RakNet@@UEAAXP6AXPEAVRakPeerInterface@2@PEAX@Z1@Z
     MCVAPI void SetUserUpdateThread(
-        void  (*_userUpdateThreadPtr)(class RakNet::RakPeerInterface*, void*),
+        void (*_userUpdateThreadPtr)(class RakNet::RakPeerInterface*, void*),
         void* _userUpdateThreadData
     );
 

src/mc/world/actor/SynchedActorDataEntityWrapper.h

@@ -7,7 +7,7 @@
 
 class SynchedActorDataEntityWrapper {
 public:
-    int                                             (**_vptr_SynchedActorDataEntityWrapper)(void);
+    int (**_vptr_SynchedActorDataEntityWrapper)(void);
     gsl::not_null<class SynchedActorDataComponent*> mData;
 
     template <typename T>