You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we identify nations in the folder structure and in the API /data/nation/{key} path by the uppercase English display name of the region. I have verified that both javascript and PHP use the same display names for nations, so it's not too much of a problem.
However, it's not so simple to derive the ISO code from the display name of the nation, especially once we've transformed it to uppercase. It's almost impossible to go from uppercase to the original display form. So there is a little bit of overhead in keeping for example a country_iso property in the /calendars metadata endpoint's national_calendars data, or in creating frontend map structures to derive the ISO code from the nation name. If we just used the ISO code to store data about nations, we wouldn't need frontend map structures, since it's easy enough to derive the display name from the ISO code. This will also provide for better folder structures, avoiding strange folder names with spaces and ampersands and whatnot.
The text was updated successfully, but these errors were encountered:
Currently, we identify nations in the folder structure and in the API
/data/nation/{key}
path by the uppercase English display name of the region. I have verified that both javascript and PHP use the same display names for nations, so it's not too much of a problem.However, it's not so simple to derive the ISO code from the display name of the nation, especially once we've transformed it to uppercase. It's almost impossible to go from uppercase to the original display form. So there is a little bit of overhead in keeping for example a
country_iso
property in the/calendars
metadata endpoint'snational_calendars
data, or in creating frontend map structures to derive the ISO code from the nation name. If we just used the ISO code to store data about nations, we wouldn't need frontend map structures, since it's easy enough to derive the display name from the ISO code. This will also provide for better folder structures, avoiding strange folder names with spaces and ampersands and whatnot.The text was updated successfully, but these errors were encountered: