Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support RC versions #5

Closed
sellmair opened this issue Aug 16, 2021 · 7 comments
Closed

Support RC versions #5

sellmair opened this issue Aug 16, 2021 · 7 comments
Assignees

Comments

@sellmair
Copy link

When applied to 1.5.30-RC:

Caused by: java.lang.IllegalStateException: Unknown meta version: RC
        at com.louiscad.complete_kotlin.internal.MetaVersion$Companion.findAppropriate(MetaVersion.kt:20)
        at com.louiscad.complete_kotlin.internal.CompilerVersion$Companion.fromString(CompilerVersion.kt:39)
        at com.louiscad.complete_kotlin.internal.CompilerVersion$Companion.current(CompilerVersion.kt:26)
        at com.louiscad.complete_kotlin.internal.TargetsHandlerKt.completePlatformKlibsIfNeeded(TargetsHandler.kt:24)
        at com.louiscad.complete_kotlin.CompleteKotlinPlugin$setup$1$1$1.execute(CompleteKotlinPlugin.kt:48)
        at com.louiscad.complete_kotlin.CompleteKotlinPlugin$setup$1$1$1.execute(CompleteKotlinPlugin.kt:16)
        at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:100)
        at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction$1.run(DefaultCollectionCallbackActionDecorator.java:95)

@LouisCAD
Copy link
Owner

Curious, I copied that code from Kotlin repo and I'm pretty sure it was supporting RC versions 🤔

If you have any idea, please let me know. I plan to investigate later this week.

@Syer10
Copy link

Syer10 commented Aug 20, 2021

@LouisCAD
Copy link
Owner

@sellmair Did Kotlin/Native distribution versioning change recently?

@sellmair
Copy link
Author

sellmair commented Sep 1, 2021

@sellmair Did Kotlin/Native distribution versioning change recently?

🤷

Where did you copy this code from the Kotlin repo?

@LouisCAD
Copy link
Owner

LouisCAD commented Sep 3, 2021

From this file, but I see that it changed since then: https://github.com/JetBrains/kotlin/blob/1.5.30/compiler/util-io/src/org/jetbrains/kotlin/konan/CompilerVersion.kt

I need to setup a GitHub Action in this repo that will let me know when one of these files changes on master.

Now that we can run Kotlin scripts out of the box in the runners, it might be a good time to do it :)

@LouisCAD LouisCAD self-assigned this Sep 3, 2021
@LouisCAD
Copy link
Owner

LouisCAD commented Jan 9, 2022

New year resolution, fix CompleteKotlin, and enable myself to fix it in time if Kotlin changes anything that clashes with CompleteKotlin.

@LouisCAD
Copy link
Owner

RC and RC2 versions with the new versioning scheme are now supported in 1.1.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants