Skip to content

bug with iterator return from tcpsock:receiveuntil #1266

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
tweyseo opened this issue Jul 1, 2022 · 4 comments
Closed

bug with iterator return from tcpsock:receiveuntil #1266

tweyseo opened this issue Jul 1, 2022 · 4 comments

Comments

@tweyseo
Copy link
Contributor

tweyseo commented Jul 1, 2022

Describe the bug
the iterator return from tcpsock:receiveuntil in your ngx.lua
---@alias ngx.socket.tcpsock.iterator fun(size:number):string,string,any
should be
---@alias ngx.socket.tcpsock.iterator fun(size:number|nil):string,string,any
see receiveuntil
@sumneko
Copy link
Collaborator

sumneko commented Jul 1, 2022

You can just make a PR for it

@sumneko
Copy link
Collaborator

sumneko commented Jul 2, 2022

fixed by #1270 1268

@sumneko sumneko closed this as completed Jul 2, 2022
@Zamiell
Copy link
Contributor

Zamiell commented Jul 2, 2022

my PR seems unrelated to this issue

@sumneko
Copy link
Collaborator

sumneko commented Jul 2, 2022

Should be #1268

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tweyseo @sumneko @Zamiell