LSP Lua suddenly stopped working: "buffer overflow detected : terminated" #1844

barryblando · 2023-01-22T10:31:53Z

How are you using the lua-language-server?

NeoVim

Which OS are you using?

Windows WSL

What is the issue affecting?

Diagnostics/Syntax Checking

Expected Behaviour

loading LSP completed

Actual Behaviour

suddenly stops working with the error "Client # quit with exit code 0 and signal 6"

Reproduction steps

open neovim
LSP loading...
suddenly stops working

Additional Notes

Using

Neovim 0.8.2
Mason
Lua-Language-Server@3.6.7

Log File

[ERROR][2023-01-22 09:49:10] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 09:49:51] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 09:50:50] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 10:00:14] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 10:00:58] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[START][2023-01-22 10:02:31] LSP logging initiated
[ERROR][2023-01-22 10:02:31] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 10:02:49] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[START][2023-01-22 10:12:27] LSP logging initiated
[ERROR][2023-01-22 10:12:27] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[START][2023-01-22 10:14:02] LSP logging initiated
[ERROR][2023-01-22 10:14:02] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 10:17:28] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"
[ERROR][2023-01-22 10:17:47] .../vim/lsp/rpc.lua:733	"rpc"	"/home/bblando0x15/.local/share/nvim/mason/bin/lua-language-server"	"stderr"	"*** buffer overflow detected ***: terminated\n"

The text was updated successfully, but these errors were encountered:

caarlos0 · 2023-01-24T02:45:53Z

for me it fails on linux amd64, same config and same project works on macos arm64 though.

JuanZoran · 2023-01-25T06:22:57Z

I meet the same problem as you, did you have found any solution for that?

JuanZoran · 2023-01-25T06:33:57Z

I try to reboot my system, then it works well

barryblando · 2023-01-25T07:29:39Z

I meet the same problem as you, did you have found any solution for that?

none at the moment. also rebooted the WSL. Same buffer overflow. Other LSPs are working

I also change the sumneko_lua config to use vscode's Lua server. Still buffer overflow.

return {
  -- cmd = { os.getenv("HOME") .. "/.local/share/nvim/mason/bin/lua-language-server" },
  cmd = { os.getenv("HOME") .. "/.vscode-server/extensions/sumneko.lua-3.6.7-linux-x64/server/bin/lua-language-server" },
  on_new_config = function(config, root)
    local libs = vim.tbl_deep_extend("force", {}, library)
    libs[root] = nil
    config.settings.Lua.workspace.library = libs
    return config
  end,
  settings = {
    Lua = {
      runtime = {
        version = "LuaJIT",
        path = path
      },
      completion = { callSnippet = "Both" },
      diagnostics = {
        globals = { "vim" }
      },
      workspace = {
        library = library,
        maxPreload = 2000,
        preloadFileSize = 50000,
        checkThirdParty = false,
      },
      telemetry = { enable = false }
    }
  }
}

Mikilio · 2023-01-25T17:16:42Z

Same issue here I tried to check if my tweaks in the recent days broke my config but that wasn't the case.
Considering that I use Nix which is hundred percent reproducible I can only imagine that something about the protocol changed.

Edit: I was using the unstable channel. Using an older version fixed the issue for me. Thanks to @deriamis for pointing that out.

deriamis · 2023-01-27T18:35:42Z

I am having the same problem, and it appears to be something introduced between versions 3.6.4 and 3.6.5. I can run version 3.6.4 without any problems at all.

sumneko · 2023-01-30T12:24:29Z

Should be something with #1835
Could you please help us @koppchen ?

kyoh86 · 2023-01-31T02:25:46Z

I am having the same problem, and it appears to be something introduced between versions 3.6.4 and 3.6.5. I can run version 3.6.4 without any problems at all.

Me too. It sounds me that something in 3.6.5 becauses the issue.

koppchen · 2023-01-31T03:37:06Z

I was able to reproduce this, and yeah it looks like the issue was introduced in v3.6.5

Tested with: neovim 0.8.2, with the linux-x64 releases from both lua-language-server and vscode-lua.

Tested the following versions:

v3.6.7 - ERROR
v3.6.6 - ERROR
v3.6.5 - ERROR
v3.6.4 - good
v3.6.3 - good
v3.6.2 - good

I did the following to reproduce the error. The lua files can be empty.

Open a lua file in one terminal and keep it open
Open a second lua file in another terminal.
If the first completed loading the workspace, the second one will error. Otherwise, either (or both) could error.

Seems I usually only have one file open, which is why I didn't notice this sooner.

koppchen · 2023-01-31T15:36:04Z

Looks like the issue was introduced in this diff. I was testing a few older versions and this is where the failures started.

7075ca1 - update filewatch

Also, i should have mentioned this in my previous comment: The error I'm seeing in the logs is a little different then the original report, but it's probably related.

[ERROR][2023-01-31 10:25:37] .../vim/lsp/rpc.lua:733   "rpc"   "lua-language-server"   "stderr"   "*** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated\n"

sumneko · 2023-01-31T18:18:23Z

How about v3.6.8?

koppchen · 2023-01-31T18:43:41Z

I got the same error with 3.6.8.

[ERROR][2023-01-31 13:41:08] .../vim/lsp/rpc.lua:733   "rpc"   "lua-language-server"   "stderr"   "*** bit out of range 0 - FD_SETSIZE on fd_set ***: terminated\n"

deriamis · 2023-01-31T19:06:12Z

I don't know if it helps you any, but I did an strace and the crash happens in the main thread when reading a bunch of incoming data from the client. I can't quite get a good gdb capture (Ubuntu and debug symbols... sigh), but the signal is getting raised down in the libc layer, so that's making me think maybe it's happening while the incoming buffer is getting filled.

xulongwu4 · 2023-02-01T04:39:25Z

I hit this issue when using the released binary on linux. Building the binary from source makes it work properly.

josemiguelo · 2023-02-01T04:54:32Z

@JuanZoran's advice of rebooting the system worked for me 🤔

deriamis · 2023-02-01T07:40:34Z

The fact that rebooting and compiling the binary seems to "fix" the problem is further evidence of some kind of memory corruption bug. I understand that the Linux binary is compiled on Ubuntu, and dollars to donuts the "release" configuration has stack and buffer overflow protection enabled. That's what the segfault actually is - a protection mechanism.

I wouldn't trust rebooting and recompiling as a "fix". The memory corruption bug, if that's what it is (and I'm as sure as I can be without actually seeing it in the code) almost certainly still exists and will continue to cause problems. It's better to downgrade to 3.6.4 instead.

sumneko · 2023-02-01T11:32:58Z

It seems that only precompiled binaries have this problem.
Does anyone encounter this problem with binaries compiled by yourself?

koppchen · 2023-02-03T03:24:09Z

I believe this is fixed in the latest 3.6.9 release, but others should confirm if they're still having problems.

That version works for me with pre-compiled binaries from both vscode-lua & lua-language-server, and building locally with luamake.

Also, I was able to build this locally with luamake, and the issue was there with 3.6.7 and 3.6.8.
The 3.6.9 tag worked successfully, but only if the submodules were synced with git submodule update --init --recursive after switching from the 3.6.8 to 3.6.9 tag. So, it looks like this was related to a change in one of the submodules.

xulongwu4 · 2023-02-03T03:53:39Z

The 3.6.9 release works for me as well.

deriamis · 2023-02-03T04:56:37Z

I can also confirm that v3.6.9 is working for me.

barryblando · 2023-02-05T02:21:40Z

3.6.9 fixed the problem, I'll close the issue.

sumneko added bug Something isn't working compile Related to compiling the server from source labels Jan 30, 2023

sumneko assigned actboy168 Jan 31, 2023

sumneko added the Info Needed More information is required label Feb 2, 2023

barryblando closed this as completed Feb 5, 2023

Uh oh!

LSP Lua suddenly stopped working: "***buffer overflow detected ***: terminated" #1844

LSP Lua suddenly stopped working: "***buffer overflow detected ***: terminated" #1844

Comments

barryblando commented Jan 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How are you using the lua-language-server?

Which OS are you using?

What is the issue affecting?

Expected Behaviour

Actual Behaviour

Reproduction steps

Additional Notes

Log File

caarlos0 commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JuanZoran commented Jan 25, 2023

Uh oh!

JuanZoran commented Jan 25, 2023

Uh oh!

barryblando commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mikilio commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deriamis commented Jan 27, 2023

Uh oh!

sumneko commented Jan 30, 2023

Uh oh!

kyoh86 commented Jan 31, 2023

Uh oh!

koppchen commented Jan 31, 2023

Uh oh!

koppchen commented Jan 31, 2023

Uh oh!

sumneko commented Jan 31, 2023

Uh oh!

koppchen commented Jan 31, 2023

Uh oh!

deriamis commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xulongwu4 commented Feb 1, 2023

Uh oh!

josemiguelo commented Feb 1, 2023

Uh oh!

deriamis commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sumneko commented Feb 1, 2023

Uh oh!

koppchen commented Feb 3, 2023

Uh oh!

xulongwu4 commented Feb 3, 2023

Uh oh!

deriamis commented Feb 3, 2023

Uh oh!

barryblando commented Feb 5, 2023

Uh oh!

LSP Lua suddenly stopped working: "buffer overflow detected : terminated" #1844

LSP Lua suddenly stopped working: "buffer overflow detected : terminated" #1844

barryblando commented Jan 22, 2023 •

edited

Loading

caarlos0 commented Jan 24, 2023 •

edited

Loading

barryblando commented Jan 25, 2023 •

edited

Loading

Mikilio commented Jan 25, 2023 •

edited

Loading

deriamis commented Jan 31, 2023 •

edited

Loading

deriamis commented Feb 1, 2023 •

edited

Loading