Skip to content

Recursive expansion on hover of generic type #1853

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
eigenbom opened this issue Jan 25, 2023 · 1 comment
Open

Recursive expansion on hover of generic type #1853

eigenbom opened this issue Jan 25, 2023 · 1 comment
Labels
feat/generic Related to generic emulation feature

Comments

@eigenbom
Copy link

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Hover

Expected Behaviour

.

Actual Behaviour

In the following code:

---@class store<T>: {set:fun(self:store<T>, key:integer, value:T), get:fun(self:store<T>, key:integer):T}

local string_store ---@type store<string>

When you hover string_store the type recursively expands leading to a confusing hover hint:

local string_store: store<string>|{ set: fun(self: store<<T>>|{ set: fun(self: store<<T>>|{ set: unknown, get: fun(self: store<<T>>|{ set: fun(self: store<<T>>|{ set: unknown, get: unknown }, key: int...(too long)...):string }

Reproduction steps

.

Additional Notes

No response

Log File

No response

@eigenbom
Copy link
Author

This bug also seems to affect auto-complete, as in this example the "clear" suggestion isn't appearing...

image

@carsakiller carsakiller added the feat/generic Related to generic emulation feature label Jan 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feat/generic Related to generic emulation feature
Projects
None yet
Development

No branches or pull requests

2 participants