Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

"play-icon.png" should be in "lychee-front/images" not root #150

Closed
SerenaButler opened this issue Dec 13, 2018 · 5 comments
Closed

"play-icon.png" should be in "lychee-front/images" not root #150

SerenaButler opened this issue Dec 13, 2018 · 5 comments
Labels
Low Priority Low priority issues
Milestone

Comments

@SerenaButler
Copy link

"play-icon.png" should be in "lychee-front/images" not root.

@ildyria
Copy link
Member

ildyria commented Dec 13, 2018

While this is correct semantically, the problem with moving it is that users don't necessarily do git submodule update after a git pull to update their server.

While the submodule update is not usually required, making such change would break it the compatibility with most users. :(

@ildyria ildyria added the Low Priority Low priority issues label Dec 13, 2018
@d7415
Copy link
Contributor

d7415 commented Dec 13, 2018

I suppose we could add a copy or symlink in a soon version, then delete it in a later version with a "may sure you "git submodule update" warning in the release notes?

In theory the release notes should be sufficient, but it's hard to be sure whether people read them.

@ildyria
Copy link
Member

ildyria commented Dec 13, 2018

There is a reason why there a is a protocol named RTFM. ;)

@LudovicRousseau
Copy link
Contributor

I think "normal" users would install or upgrade Lychee using the provided .zip file from https://github.com/LycheeOrg/Lychee/releases

"Advanced" users can use git update but I expect they know what they do.
I added a "Update the source code" section in https://github.com/LycheeOrg/Lychee/wiki/Build#update-the-source-code just in case.

@d7415
Copy link
Contributor

d7415 commented Dec 13, 2018

@LudovicRousseau If they are already in Lychee-front and building from there there shouldn't be an issue :) It's the in-between users that are likely to cause problems. But you make a good point. I propose we make the change with a new release though so that there's a little more warning.

@d7415 d7415 added this to the v3.2.8 milestone Dec 13, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Low Priority Low priority issues
Projects
None yet
Development

No branches or pull requests

4 participants