-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[TSK-51] refactor: 입학타입 상세 #88
Merged
The head ref may contain hidden characters: "refactor/\uC785\uD559\uD0C0\uC785-\uC0C1\uC138"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
admission
관련 비즈니스 로직의 네이밍을 일관성 있게 리팩토링admission
관련 CRUD Controller, Service, Repository 구현admission
관련 통합 테스트와 리포지토리 테스트 추가🤔 고민했던 부분
admission
기능에서 사용되는 네이밍이 통일되지 않아 코드 가독성이 떨어질 수 있다는 고민이 있었습니다. 이를 해결하기 위해 네이밍을 일관되게 수정하여 가독성을 향상했습니다.AdmissionTypeDetail
기능에 대한 통합 테스트와 리포지토리 테스트를 추가해 주요 비즈니스 로직의 안정성을 확인할 수 있도록 했습니다.🔊 도움이 필요한 부분
admission
관련 비즈니스 네이밍 리팩토링이 일관성 있게 잘 적용되었는지 리뷰 부탁드립니다. 팀원들의 의견이 일관성 유지와 가독성 향상에 큰 도움이 될 것입니다.