Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Banner for default playnite library #8

Closed
daephx opened this issue May 21, 2022 · 5 comments
Closed

Banner for default playnite library #8

daephx opened this issue May 21, 2022 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@daephx
Copy link

daephx commented May 21, 2022

The library banners don't include an image for the default Playnite library which all my emulated games were imported under.
So, I created one and dropped it into the folder and it seems to have worked.

Care to add it to the project?

Playnite


Edit: I didn't see that this was modeled after eMixedNite and it seems that project has one as well, but it looks a bit lower-res around the icon.

And as an extension of this issue, I don't seem to have any platform specific banners like in the recent screenshots.
e.g. Atari 2600, Gameboy Color, Sony PlayStation 2, PC

@MCC321-QC
Copy link
Owner

I removed the Playnite banner because the Library banners are loaded after the Platform banners so you would not see the Platform banners.

For example, when you see a Steam banner it means there is also a "PC" platform banner underneath it because its a PC game.
(If you added the Platform banners correctly in the Library Manager(CTRL+W) like describe here)

As every games you manually add, PC or emulated, goes in the "Playnite Library", you would see the Playnite banner instead of the platform one if it was still in there.

But the way banners a loaded may change soon. The goal would be to included Platform Banners.

@MCC321-QC MCC321-QC self-assigned this May 26, 2022
@MCC321-QC MCC321-QC added the question Further information is requested label May 26, 2022
@daephx
Copy link
Author

daephx commented May 26, 2022

Man, all too often I glance right over some important info 'right' there in the readme.
Appreciate the info, I wasn't aware of the overwrite problem. To clarify, this is what you mean correct?
Where the details box art on the right still says Steam while the library grid on the left are set to PC.

image

@MCC321-QC
Copy link
Owner

What I mean is that when you see a Library banner, there is in fact the platform banner underneath it too so that is why there is no Playnite Library banner, So you can have both Library banner AND Platform banner at the same time.

For your Library banners not showing in GridList, maybe you have Library banners disable/uncheck in the constant menu of ThemeModifier?

@daephx
Copy link
Author

daephx commented May 30, 2022

After messing with it and rereading your response, I get what you meant and understand the decision.
I'll likely be leaving the Playnite banner disabled on my setup as well to better differentiate games.

I was initially looking at the big box art not displaying the changes from ThemeModifier's toggle button.
Probably would have been better illustrated using a GIF, but it is a separate issue altogether.

Screenshot

Playnite DesktopApp_dfjkPzxQNU

Regardless, thanks for the information and hopefully the future implementation of banner loading works out! Should you reintroduce the Playnite library banner in the future you're free to use the one I posted should you choose to.

@MCC321-QC
Copy link
Owner

Platform banner added in v3.0 and I also added a settings to enable/disable the Playnite banner and I used yours. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants