Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move testing data into OSF #44

Closed
eurunuela opened this issue Feb 12, 2021 · 1 comment · Fixed by #45
Closed

Move testing data into OSF #44

eurunuela opened this issue Feb 12, 2021 · 1 comment · Fixed by #45
Labels
Effort: Low Good First Issue Good for newcomers Impact: High Priority: Medium Tests Pytest and automatic testing on CircleCI

Comments

@eurunuela
Copy link
Collaborator

Summary

We could make the package much lighter by moving the data we use for testing into an OSF repository.

Next Steps

  • Create an OSF repo for aroma under ME-ICA.
  • Upload files under tests/data to the OSF repo.
  • Write a function to download files for testing in conftest.py.
  • Remove the tests/data directory.
@eurunuela eurunuela added Good First Issue Good for newcomers Tests Pytest and automatic testing on CircleCI labels Feb 12, 2021
@eurunuela eurunuela mentioned this issue Feb 12, 2021
Merged
@eurunuela
Copy link
Collaborator Author

Files are available here: https://osf.io/6jda8/files/

I will open a PR now to update the tests.

@eurunuela eurunuela mentioned this issue Feb 12, 2021
Merged
@eurunuela eurunuela mentioned this issue Nov 19, 2021
Closed
Repository owner moved this from Todo to Done in Aroma: Python-only version Nov 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Effort: Low Good First Issue Good for newcomers Impact: High Priority: Medium Tests Pytest and automatic testing on CircleCI
Projects
Aroma: Python-only version
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Download data from OSF for testing eurunuela/aroma
1 participant
@eurunuela