Skip to content

Commit f3dea17

Browse files
committed
Update url-loader to 2.0.1
This closes facebook#7359 by making IMAGE_INLINE_SIZE_LIMIT=0 actually disable image inlining. We use url-loader's `limit` option to set the line at which images will be inlined, and we basically expose this option to our end users via the IMAGE_INLINE_SIZE_LIMIT environment variable. Most people using it want to disable inlining images all together (the major motivator for adding it at all was I think for strict CSP), and our documentation said setting the value to zero would do that. However, it did the opposite: url-loader treated zero as "no limit". The update to 2.x fixes this; zero means nothing gets inlined. The other changes from the version bump shouldn't affect us: - minimum node version is 8.9.x, we already require 8.10.x - the limit was "greater than", is now "greater than or equal to"
1 parent 9938224 commit f3dea17

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"style-loader": "0.23.1",
7676
"terser-webpack-plugin": "1.2.3",
7777
"ts-pnp": "1.1.2",
78-
"url-loader": "1.1.2",
78+
"url-loader": "2.0.1",
7979
"webpack": "4.35.0",
8080
"webpack-dev-server": "3.2.1",
8181
"webpack-manifest-plugin": "2.0.4",

0 commit comments

Comments
 (0)