Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The xudt label style is abnormal. #646

Closed
FrederLu opened this issue May 6, 2024 · 3 comments
Closed

The xudt label style is abnormal. #646

FrederLu opened this issue May 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@FrederLu
Copy link

FrederLu commented May 6, 2024

Design Draft(12-2--12-3):
#620 (comment)

Staging:
https://ckb-explorer-frontend-in-magickbase-repo-g9u2mzhhy-magickbase.vercel.app/xudts
image
image
The style and UI on Staging are consistent.

Testnet:
https://pudge.explorer.nervos.org/xudts?page=2
image
image
image

Mainnet:
https://explorer.nervos.org/xudts?page=10
image

There are differences in xudt tags and staging on testnet/mainnet.

@FrederLu FrederLu added the bug Something isn't working label May 6, 2024
@poor-defined poor-defined moved this to 📌CurrentWeek in CKB Explorer May 6, 2024
@Keith-CY
Copy link
Member

Keith-CY commented May 6, 2024

I've updated 2 points

  1. The style of layer 1 asset and layer 2 asset was the same
image

I made them different, in their own primary colors, respectively

Bitcoin:
image
CKB Mainnet:
image
CKB Testnet:
image

  1. Tag is now interactive, e.g. https://pudge.explorer.nervos.org/xudts?tags=layer-2-asset

@Kirl70
Copy link

Kirl70 commented May 6, 2024

The adjusted tag colors have been synchronized with the design draft.
There's another area that can be optimized. If we don't limit the length of the names, I think it would be better to place the tag below the name for a better user experience.

Design Draft:
https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=37300%3A49637&mode=design&t=3EagBbH36bdpGb5O-1
image

@poor-defined
Copy link
Contributor

I'm going to close this issue coz the UI has been updated.

@poor-defined poor-defined moved this from 📌CurrentWeek to ✅ Done in CKB Explorer May 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants