Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Introduce environment variable to control dovecot full-text-search #1538

Merged
merged 3 commits into from
Aug 9, 2020

Conversation

tremlin
Copy link
Contributor

@tremlin tremlin commented Jun 14, 2020

What type of PR?

Enhancement

What does this PR do?

In #1320 a full-text-search feature was enabled in Dovecot by default. Since this can have a big impact on performance, I think it's preferable to offer an option to disable the feature if it is not needed. This PR doesn't change the default behavior (FTS on).

Related issue(s)

Prerequistes

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordinagly
  • Unless it's docs or a minor change: add changelog entry file.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2020

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request Jun 14, 2020
@bors
Copy link
Contributor

bors bot commented Jun 14, 2020

try

Build succeeded:

@ofthesun9
Copy link
Contributor

ofthesun9 commented Jun 15, 2020

Thanks for your PR.
Could you please amend it to add a description in the advanced settings in the various .env templates:

  • docs/compose/.env
  • setup/flavors/compose/mailu.env

And/or in docs/configuration.rst

@tremlin
Copy link
Contributor Author

tremlin commented Jul 12, 2020

Thanks for your suggestion. I tried to add some basic documentation.

@Nebukadneza Nebukadneza added 1.8 priority/p1 (Critical) bug with workaround / Should have type/enhancement Enhances existing functionality labels Aug 8, 2020
Copy link
Member

@Nebukadneza Nebukadneza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks simple and great, with the docs added, i’d love this for 1.8-rc! Thanks!

@Nebukadneza Nebukadneza added this to the 1.8-rc milestone Aug 8, 2020
@Nebukadneza Nebukadneza removed the 1.8 label Aug 8, 2020
Copy link
Member

@HorayNarea HorayNarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved in meeting with @Nebukadneza :D

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 9, 2020

Build succeeded:

@bors bors bot merged commit 535b95b into Mailu:master Aug 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
priority/p1 (Critical) bug with workaround / Should have type/enhancement Enhances existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants