Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI default tests for async branch are completely broken #1367

Open
jinnatar opened this issue Sep 24, 2023 · 0 comments
Open

CI default tests for async branch are completely broken #1367

jinnatar opened this issue Sep 24, 2023 · 0 comments

Comments

@jinnatar
Copy link
Contributor

jinnatar commented Sep 24, 2023

Any PR to branch async triggers a tox run. The env for the run comes from docker/.dev.env but even if I patch it for async compat with:

THERAIDMAPPER_APK_STORAGE_INTERFACE=fs
THERAIDMAPPER_CACHE_HOST=redis

.. that just triggers more failures that seem to indicate most tests were never ported for async.

I propose deleting the tests since they:

  1. Make most PRs to async fail automated checks (that can never succeed)
  2. Provide a false sense of security, since clearly they aren't actually testing for anything since they are nonfunctional.

As they've been in this state for quite a while, I'm assuming fixing the tests is not a priority. Hence I'm proposing deleting most of them as dead weight, allowing any actually functioning tests to run cleanly. (Assuming any of them actually work, I'm not seeing any succeed.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant