Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LCD BTN not work well. VIKI 2. #4127

Closed
fbarcenas opened this issue Jun 23, 2016 · 9 comments
Closed

LCD BTN not work well. VIKI 2. #4127

fbarcenas opened this issue Jun 23, 2016 · 9 comments

Comments

@fbarcenas
Copy link

Some weeks i don't update with the last rcbugfix. Today i do and what is my surprise than the button of the LCD when i press the beeper always sound BUT not go inside the menus... some times work, another times not... is really desperate.

Some idea?

@fbarcenas
Copy link
Author

fbarcenas commented Jun 23, 2016

If i change:

#define BEEPER_PIN 61

to

//#define BEEPER_PIN 61

all works!!!

problem with the BEEPER?

@jbrazio
Copy link
Contributor

jbrazio commented Jun 23, 2016

Maybe, what is your setting for #define SPEAKER ?

@fbarcenas
Copy link
Author

fbarcenas commented Jun 23, 2016

is:

//#define SPEAKER

@thinkyhead
Copy link
Member

thinkyhead commented Jun 24, 2016

@fbarcenas What kind of LCD? Does enabling SPEAKER allow you to play musical tones?

@jbrazio Sounds like a crappy debouncer. Previously the delay in the beep() function helped ensure that "flaky" buttons wouldn't have this problem. (Which they all are on these units - the on/off state "flickers" when you press them.) To address this, we need to either put the delay back into lcd_quick_feedback or make a more reliable debouncer.

@fbarcenas Try this…

  void lcd_quick_feedback() {
    lcdDrawUpdate = LCDVIEW_CLEAR_CALL_REDRAW;
    next_button_update_ms = millis() + 500;

    #if ENABLED(LCD_USE_I2C_BUZZER)
      lcd.buzz(LCD_FEEDBACK_FREQUENCY_DURATION_MS, LCD_FEEDBACK_FREQUENCY_HZ);
    #elif PIN_EXISTS(BEEPER)
      buzzer.tone(LCD_FEEDBACK_FREQUENCY_DURATION_MS, LCD_FEEDBACK_FREQUENCY_HZ);
-   #else
-     delay(LCD_FEEDBACK_FREQUENCY_DURATION_MS);
    #endif
+   delay(LCD_FEEDBACK_FREQUENCY_DURATION_MS);
  }

@fbarcenas
Copy link
Author

fbarcenas commented Jun 24, 2016

i use VIKI 2

Yes i can play musical tones.

@thinkyhead
Copy link
Member

thinkyhead commented Jun 24, 2016

Yes i can play musical tones.

Uncomment #define SPEAKER for best results. I believe that if you insert the suggested delay in lcd_quick_feedback the button will be more reliable, and the click sound will work.

@jbrazio
Copy link
Contributor

jbrazio commented Aug 1, 2016

@fbarcenas can we close this ticket, is your problem solved ?

@boelle
Copy link
Contributor

boelle commented Aug 11, 2016

i think this one can be closed... it should not take 10 days to respond

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

4 participants