refactor(dao) better full update handling in DAO and API #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stronger schema validation and more edge-cases to validation during partial and complete update. With tests. - base_dao `update()` now fetches the old entity and compare the changes before performing any update, allowing us to cover more edge-cases. - Admin API can directly use the `self.params` property since the CRUD `update()` method does not need the old entity anymore. - Fix for #765 - Fix for #720 PS: the schema validation thing is a total mess. PUT method can be improved (see @todo annotations).
thibaultcha
added
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Dec 23, 2015
refactor(dao) better full update handling in DAO and API
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor that has the benefit of fixing two issues with
PUTrequests.partial and complete update. With tests.
update()now fetches the old entity and compares the changesbefore performing any update, allowing us to cover more edge-cases.
self.paramsproperty since the CRUDupdate()method does not need the old entity anymore.created_atfields immutable.PS: the schema validation thing is a total mess. PUT method can be
improved (see @todo annotations).