Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Formula is incorrect for charged compounds #349

Open
tsufz opened this issue Aug 14, 2023 · 3 comments
Open

Formula is incorrect for charged compounds #349

tsufz opened this issue Aug 14, 2023 · 3 comments

Comments

@tsufz
Copy link
Member

tsufz commented Aug 14, 2023

The validator catch for example:

Formula from CH$IUPAC: [C27H42NO2]+ (estimated by validator)
Formula from CH$FORMULA: C27H42NO2 (used in record)

for Benzethonium.

Should be correct as the smiles is correctly annotated.

@tsufz tsufz added the bug label Aug 14, 2023
@tsufz tsufz added this to the Adduct and formula annotation milestone Aug 14, 2023
@tsufz
Copy link
Member Author

tsufz commented Aug 14, 2023

See comment by @meier-rene in MassBank/MassBank-data#237 (comment) how the validator handles smiles, iupac, formulas.

@tsufz
Copy link
Member Author

tsufz commented Aug 16, 2023

@sneumann, @meowcat and @schymane, any opinion on @meier-rene 's suggestions?

@schymane
Copy link
Member

@schymane is in poor connectivity and unable to comment with traces/comments now spread across multiple issues. Seems there are inconsistencies with how major resources/ toolkits handle this and we should decide how to deal with this carefully.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants