Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

True Type font glyphs have error on some characters #4066

Closed
larsbrubaker opened this issue Dec 6, 2018 · 8 comments
Closed

True Type font glyphs have error on some characters #4066

larsbrubaker opened this issue Dec 6, 2018 · 8 comments
Labels
bug polish Quality needs to be improved

Comments

@larsbrubaker
Copy link
Member

@larsbrubaker commented on Mon Dec 03 2018

image.png

This seems to be a parsing bug in IGlyphReaderExtensions. The 'O' in particular looks like it has an error figuring out if it is in a curve or not and renders the LineTo that seems out of place.

@prepare, any insight or suggestions you might have in how to fix this would be incredibly appreciated.

@larsbrubaker larsbrubaker added polish Quality needs to be improved bug labels Dec 6, 2018
@larsbrubaker
Copy link
Member Author

Put up a bounty on this bug as a test. First time trying this out.

https://www.bountysource.com/issues/67138827-true-type-font-glyphs-have-error-on-some-characters

@prepare
Copy link

prepare commented Dec 7, 2018

hello, @larsbrubaker

Could you provide that font ?

eg. via direct download or git

@larsbrubaker
Copy link
Member Author

larsbrubaker commented Dec 7, 2018

It can be found in:
MatterControl\StaticData\FontsAlfa_Slab.ttf
https://github.com/MatterHackers/MatterControl/tree/master/StaticData/Fonts

BTW: Do you have a 3D printer? We would by happy to send you a spool of filament for all the help you have provided.

@prepare
Copy link

prepare commented Dec 7, 2018

The bug is fixing , and I will send a PR soon.

fixing_ttf
pic 1: before fixing, FontsAlfa_Slab.ttf


fixing_ttf2

pic 2: after

Thank you for your report :)

@prepare
Copy link

prepare commented Dec 7, 2018

This PR => MatterHackers/agg-sharp#1112 will fix this problem

@larsbrubaker
Copy link
Member Author

Thank you. So nice to have this fixed.

@larsbrubaker
Copy link
Member Author

@prepare you should claim the bounty in bountysource. It is only 15$ but you still did the work and it is very helpful.

@prepare
Copy link

prepare commented Dec 9, 2018

@larsbrubaker ,
Thank you for your kindness.

At this time, I can't accept the bounty,

But Feel free to send any bugs/ suggestion to me.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug polish Quality needs to be improved
Projects
None yet
Development

No branches or pull requests

2 participants