Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Framework Restructure #38

Closed
BobDotCom opened this issue Feb 24, 2024 · 1 comment
Closed

Framework Restructure #38

BobDotCom opened this issue Feb 24, 2024 · 1 comment

Comments

@BobDotCom
Copy link
Contributor

I believe a framework such as React would be beneficial to the project, for a couple of reasons.

  1. There's currently a bunch of duplication between pages. I partially addressed this in Major CSS updates #37 for the CSS, but without a framework there's not much that can be done about html duplication. A framework would allow for elements to be broken down into separate files and imported into each page.
  2. It would help with performance. React would optimize how the DOM is updated using react states and effect hooks.
  3. Better maintainability. It would abstract away the need for code to update the DOM. TSX is a quite powerful tool for templating.

And a couple more reasons, but I'll keep it short for now.

I'd be willing to work on a restructure like this, but first I'd like to check if you (@MaximilianAdF) are willing/able to maintain it. If you don't know React or would prefer not to use it, a refactor wouldn't make sense. If you'd like me to go more in-depth about the benefits (and any possible downsides), let me know.

@MaximilianAdF
Copy link
Owner

Although I am not super familiar with React I think it's a great idea to implement React as a framework, especially as a learning method. This upcoming week I will be rather preoccupied, but as soon as it starts to alleviate I would be more than happy to work on this restructure.

@BobDotCom BobDotCom mentioned this issue Feb 26, 2024
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants