Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

code_style --since doesn't work properly with the framework submodule #9404

Closed
gilles-peskine-arm opened this issue Jul 17, 2024 · 2 comments
Labels
bug component-platform Portability layer and build scripts

Comments

@gilles-peskine-arm
Copy link
Contributor

I'm working on a branch forked from mbedtls-3.6 (for example — it could also be development). I run

scripts/code_style.py --since upstream-public/mbedtls-3.6

I expect this to report on the changes made since my branch forked from mbedtls-3.6. But this fails on files in the framework submodule because the script uses the branch name inside the submodule, instead of getting the submodule commit from the toplevel repository's commit.

subprocess.CalledProcessError: Command '['git', '-C', 'framework', 'log', 'upstream-public/mbedtls-3.6..HEAD', '--name-only', '--pretty=', '--', 'psasim/include/psa/client.h', 'psasim/include/psa/error.h', 'psasim/include/psa/lifecycle.h', 'psasim/include/psa/service.h', 'psasim/include/psasim/init.h', 'psasim/src/client.c', 'psasim/src/common.c', 'psasim/src/common.h', 'psasim/src/service.c', 'psasim/test/client.c', 'psasim/test/server.c']' returned non-zero exit status 128.
@ronald-cron-arm
Copy link
Contributor

I think we have already Mbed-TLS/mbedtls-framework#24 to track that issue, thus we probably do not need this additional one.

@gilles-peskine-arm
Copy link
Contributor Author

Ah, right, sorry, I forgot to check the framework repository since code_style.py is still in the main repo.

@gilles-peskine-arm gilles-peskine-arm closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@github-project-automation github-project-automation bot moved this to Done in Friction Jul 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug component-platform Portability layer and build scripts
Projects
Status: Done
Development

No branches or pull requests

2 participants