Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove legacy API usage from ssl_server2.c #9978

Open
davidhorstmann-arm opened this issue Feb 13, 2025 · 1 comment
Open

Remove legacy API usage from ssl_server2.c #9978

davidhorstmann-arm opened this issue Feb 13, 2025 · 1 comment
Labels
size-m Estimated task size: medium (~1w)

Comments

@davidhorstmann-arm
Copy link
Contributor

davidhorstmann-arm commented Feb 13, 2025

Part of implementing #9904

Remove uses of the legacy crypto API from ssl_server2.c. Changes needed are:

  • Remove the option to set custom DHM parameters with the dhm_file option. This removal is needed because the mbedtls_dhm functions are going away.
  • Rewrite the ssl_async_resume() function to remove the ASYNC_OP_DECRYPT operation and thereby remove the use of mbedtls_pk_sign(). This is going away anyway in Remove the RSA-decryption key exchange #9682 so there is no problem with removing it.

This task is done when ssl_server2.c no longer calls any legacy function.

Estimate: 6 Ideal Engineering Hours

@davidhorstmann-arm davidhorstmann-arm added the size-m Estimated task size: medium (~1w) label Feb 13, 2025
@davidhorstmann-arm davidhorstmann-arm moved this to Implementation needed in Mbed TLS 4.0 planning Feb 13, 2025
@gilles-peskine-arm
Copy link
Contributor

Regarding ssl_async_resume: we're removing RSA-decryption authentication. As part of that, the mbedtls_ssl_async_decrypt_t callback is going away. So ssl_async_resume will no longer need to handle decryption.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size-m Estimated task size: medium (~1w)
Projects
Status: Implementation needed
Development

No branches or pull requests

2 participants