Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

implement dasp::signal::Signal on ReadDiskStream #7

Open
Be-ing opened this issue Dec 11, 2021 · 2 comments
Open

implement dasp::signal::Signal on ReadDiskStream #7

Be-ing opened this issue Dec 11, 2021 · 2 comments

Comments

@Be-ing
Copy link
Collaborator

Be-ing commented Dec 11, 2021

I find the API of ReadDiskStream unintuitive:

let ch1 = read_data.read_channel(0);
let ch2 = read_data.read_channel(1);
for f in 0..frames {
  self.buffer[f * 2] = ch1[f];
  self.buffer[f * 2 + 1] = ch2[f];
}

It would be nice to implement dasp::signal::Signal on this type.

@Be-ing
Copy link
Collaborator Author

Be-ing commented Dec 13, 2021

Related: RustAudio/dasp#168

@BillyDM
Copy link

BillyDM commented Dec 13, 2021

Possibly, I'll think on it. I'm currently busy with other stuff at the moment.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants