-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: 임시 반응형 UI 적용(모바일 한정) #227
Conversation
|
||
interface MuiDatepicker { | ||
handleChange: (value: Date | null) => void; | ||
defaultValue?: Date; | ||
value?: Date; | ||
inputRef?: React.Ref<HTMLInputElement>; | ||
invalid?: boolean; | ||
type?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type 프로퍼티를 추가한 이유가 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전에 시작일을 선택하면 종료일을 선택할 때, 시작일 이후만 진한 UI가 되도록 하는 요청이 있어서 추가하여 사용했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그래서 시작일 이전 날짜는 선택 못하도록 했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오! 저도 그럼 해당 부분을 적용하고 싶은데 지금으로써는 const formData = useRecoilValue(recruitInputState);
만 가능한거죠??!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 그렇군요..!! 이 부분도 공통으로 사용할 수 있도록 코드를 수정해봐야겠네요!
저는 구인글을 생성할 때, 백엔드로 formData를 전송하고 있어요! 수연님도 구현하시게 되면 어떻게 하는게 좋을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 해당 PR보다는 따로 이슈를 파서 하는게 좋을 것 같네요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵~! 일단 인지하고 저도 함 더 고민해봐야 할 부분인것 같아요!
max-width 에 대한 450, 431 등의 수치는 어떤 기준으로 나누신건지 궁금합니다! |
db67cc8
to
71b9a46
Compare
cedddc6
to
b90528e
Compare
src/components/recruit/create/basicInformation/BasicInformation.tsx
Outdated
Show resolved
Hide resolved
|
||
interface MuiDatepicker { | ||
handleChange: (value: Date | null) => void; | ||
defaultValue?: Date; | ||
value?: Date; | ||
inputRef?: React.Ref<HTMLInputElement>; | ||
invalid?: boolean; | ||
type?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오! 저도 그럼 해당 부분을 적용하고 싶은데 지금으로써는 const formData = useRecoilValue(recruitInputState);
만 가능한거죠??!
아하! 이해했습니다! 근데 왜 430이 아닌 431로 1을 더하신건지 궁금합니다! 혹시 이부분도 별도의 이유가 있나용?! |
제 착각이었는지 기억이 나지 않는데, 딱 430으로 맞추니까 안 되었던거 같아서? 그런거 같습니다..! |
구현 내용/방법
To Do
리뷰 필요
close #201