feat: 프로필 상세 페이지 UI 및 기능 및 API 연동 구현 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이유: svg 파일로 별도로 저장
- 이유: useParams으로 불러올 키워드가 라우팅 경로와 동일해야 함
kimsuyeon0916
added
Priority: Critical
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
prgmr99
approved these changes
Mar 18, 2024
| @@ -185,6 +169,7 @@ const MemberTest = ({ id }: Member) => { | |||
| const [memberList, setMemberList] = useRecoilState(memberListState); | |||
|
|
|||
| const onClickDelete = (event: React.MouseEvent<HTMLDivElement>) => { | |||
| // eslint-disable-next-line prefer-const | |||
There was a problem hiding this comment.
제가 esLint 자동 저장 시에 바로 적용되어 변수 선언 시 const 키워드만을 사용하는 옵션때문에 코드가 자꾸 수정되어,,, 해당 주석으로 막았습니다ㅠㅠ..🥹
Comment on lines
32
to
34
| if (event.target instanceof Element) { | ||
| const deletedIndex = Number(event.target.id); | ||
| temp.splice(deletedIndex, 1); |
There was a problem hiding this comment.
수연님 혹시 이거 삭제 제대로 되셨나요??!
제가 이번에 역할 삭제 부분을 구현하면서 그때 생긴 버그의 원인을 알게되어서 다음에 공유해드리겠습니다!!!
There was a problem hiding this comment.
넵 감사합니다!!😊 해결되서 다행이네요!!👍🏻
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용/방법
리뷰 필요
ProfileImage.tsx)를 사이즈를 조절 가능하도록 수정하였습니다! 나중에 프로필 원형 이미지 사용하실 때 해당 컴포넌트를 사용하시면 좋을 것 같습니다Profile.styled.ts내 typograpy를 h2 ~ h6 까지 정리해놓았습니다. 추후에 디자인 시스템이 도입되면 해당 부분을 별도의 파일로 분리할 예정입니다!제가 놓친 부분이 있다면 말씀 부탁드립니다!
close #70