Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Console Warnings #397

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix Console Warnings #397

merged 1 commit into from
Dec 17, 2024

Conversation

jonashae
Copy link
Contributor

Description

  • add toRefs quickfix in OlTileLayer.vue, props should not bei writeable, so I change the props to a ref. To really solve this issue it would be better to change the props to a model. But this would take a lot more time.
  • make options in usePropsAsObjectProperties.ts reactive to fix the warning in the console that it expected a reactive object and get a plain one.

Motivation and Context

Fix issue #396 and #393

How Has This Been Tested?

I run the vite test and the testet it in componentsguide/layers/tilelayer/

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Tests
  • Other (Tooling, Dependency Updates, etc.)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a new test.

If you added a new component feature (layer, geom, source, etc.), please be sure to update the documentation:

  • Add component to output.globals in vite.config.ts
  • Provide at least one simple snapshot test (see test directory)
  • Create a src/demos/<Component>Demo.vue
  • Create a docs/componentsguide/<Category>/<Feature>/index.md containing the Demo and documentation for the component
  • Add the docs page to docs/.vitepress/config.ts

- add toRefs quickfix in OlTileLayer.vue, props should not bei writeable, so I change the props to a ref
- make options reactive to fix the warning in the console
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit 4e36625
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/675abeb09d0f8000085f2f19
😎 Deploy Preview https://deploy-preview-397--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@d-koppenhagen d-koppenhagen merged commit 82aff4c into MelihAltintas:main Dec 17, 2024
4 checks passed
@KristynaBartosova
Copy link

The fix works perfectly, thank you! ❤️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants