-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
NEMOVAR interface to orca-jedi/JEDI #125
Comments
One note would be, I think its important to ensure we can build without nemovar for compatibility with the NG-PAO project. So at the CMAKE level perhaps we can use a switch to decide whether we build with nemovar interface or not? |
I have been looking over examples in SABER and trying ot understand your prototype change. I think it would be better if we could get the part of your change that lives in the saber namespace into saber itself, similar to the way this is done for NOAAs GSI. They package their covariance fortran routines as a library and then interface to them as part of saber if the library is found: Here is the switch they use: https://github.com/JCSDA-internal/saber/blob/48c0f95b83a946277d8c7bcd7c95af898f0d8da3/CMakeLists.txt#L75 and the GSI stuff is here: https://github.com/JCSDA-internal/saber/tree/develop/src/saber/gsi |
That's useful I guess they've pioneered a way to get my NEMOVAR interface into SABER. Although NEMOVAR does it's own geometry setup and so a user would need to some extra work to use a non-standard grid. Perhaps GSI is more generic and can use the altas geometry data directly which may aid in its SABER acceptability. I'm giving a DA science meeting talk next week (3 Dec at 11am) about my JEDI work and I'll make a point to raise the question about where to put the interface code. |
@frld sounds good to me! My reasoning that this belongs in SABER is really from a few different directions:
|
I've opened an issue on the SABER repo https://github.com/JCSDA-internal/saber/issues/980 |
Description
Include code to allow orca-jedi and NEMOVAR to interface.
More details to follow...
I've created a branch with some developments but note this is not necessarily the final form the interface will take
https://github.com/MetOffice/orca-jedi/tree/feature/nemovar_interface
Acceptance Criteria (Definition of Done)
TBC
Dependencies
TBC
The text was updated successfully, but these errors were encountered: