AssetsContractController: Unit tests fail on external endpoints #1213

legobeat · 2023-04-19T07:49:23Z

Description

The assets-controller tests are failing when run locally. Is there some additional setup needed for proxying the requests properly..?

As can be seen in the log below, the tests fail on the requests to the metafi endpoints. However, from the same shell that the tests are run from, the same endpoint responds without issues:

$ curl -i https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset_contract/0x495f947276749Ce646f68AC8c248420045cb7b5e
HTTP/2 200
date: [...]
content-type: application/json
x-trace-id: [...]
vary: Accept, Origin, Accept-Encoding
allow: GET, OPTIONS
cache-control: public, max-age=300
age: 10
x-frame-options: DENY
x-frame-options: SAMEORIGIN
x-content-type-options: nosniff
referrer-policy: same-origin
cross-origin-opener-policy: same-origin
cf-cache-status: DYNAMIC
last-modified: [...]
strict-transport-security: max-age=15724800; includeSubDomains
server: cloudflare
cf-ray: [...]

Environment

Fresh checkout and node_modules from current main.

$ env | grep -i proxy

$ node --version
v18.13.0

$ yarn --version
3.3.0

Log

# inside `packages/assets-controllers`
$ yarn test

[...]

 PASS   assets-controllers  src/NftController.test.ts (46.552 s)
  ● Console

    console.error
      FetchError {
        message: 'request to https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset_contract/0x495f947276749Ce646f68AC8c248420045cb7b5e failed, reason: Failed to fetch',
        type: 'system',
        errno: undefined,
        code: undefined
      }

      534 |       error === TIMEOUT_ERROR)
      535 |   ) {
    > 536 |     console.error(error);
          |             ^
      537 |   } else {
      538 |     throw error;
      539 |   }

      at logOrRethrowError (../controller-utils/src/util.ts:536:13)
      at ../controller-utils/src/util.ts:370:5
          at Generator.throw (<anonymous>)
      at rejected (../controller-utils/src/util.ts:6:65)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

    console.error
      FetchError {
        message: 'request to https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset_contract/0x6EbeAf8e8E946F0716E6533A6f2cefc83f60e8Ab failed, reason: Failed to fetch',
        type: 'system',
        errno: undefined,
        code: undefined
      }

      534 |       error === TIMEOUT_ERROR)
      535 |   ) {
    > 536 |     console.error(error);
          |             ^
      537 |   } else {
      538 |     throw error;
      539 |   }

      at logOrRethrowError (../controller-utils/src/util.ts:536:13)
      at ../controller-utils/src/util.ts:370:5
          at Generator.throw (<anonymous>)
      at rejected (../controller-utils/src/util.ts:6:65)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

    console.error
      FetchError {
        message: 'request to https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset_contract/0x60F80121C31A0d46B5279700f9DF786054aa5eE5 failed, reason: Failed to fetch',
        type: 'system',
        errno: undefined,
        code: undefined
      }

      534 |       error === TIMEOUT_ERROR)
      535 |   ) {
    > 536 |     console.error(error);
          |             ^
      537 |   } else {
      538 |     throw error;
      539 |   }

      at logOrRethrowError (../controller-utils/src/util.ts:536:13)
      at ../controller-utils/src/util.ts:370:5
          at Generator.throw (<anonymous>)
      at rejected (../controller-utils/src/util.ts:6:65)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

    console.error
      FetchError {
        message: 'request to https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset/0x60F80121C31A0d46B5279700f9DF786054aa5eE5/1144858 failed, reason: Failed to fetch',
        type: 'system',
        errno: undefined,
        code: undefined
      }

      534 |       error === TIMEOUT_ERROR)
      535 |   ) {
    > 536 |     console.error(error);
          |             ^
      537 |   } else {
      538 |     throw error;
      539 |   }

      at logOrRethrowError (../controller-utils/src/util.ts:536:13)
      at ../controller-utils/src/util.ts:370:5
          at Generator.throw (<anonymous>)
      at rejected (../controller-utils/src/util.ts:6:65)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

 FAIL   assets-controllers  src/AssetsContractController.test.ts (56.857 s)

[...]

------------------------------------|---------|----------|---------|---------|---------------------------
File                                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------------------|---------|----------|---------|---------|---------------------------
All files                           |   96.73 |    89.39 |    96.2 |   96.65 |
 src                                |   97.99 |    91.71 |   97.79 |   97.94 |
  AccountTrackerController.ts       |   98.25 |    83.33 |     100 |   98.15 | 186
  AssetsContractController.ts       |   97.47 |    93.55 |     100 |   97.47 | 187,371
  CurrencyRateController.ts         |     100 |      100 |     100 |     100 |
  NftController.ts                  |   98.11 |    88.52 |     100 |   98.08 | 269,395,1125,1188,1257
  NftDetectionController.ts         |   95.31 |    85.37 |   93.75 |   95.08 | 181,270,284
  TokenBalancesController.ts        |     100 |      100 |     100 |     100 |
  TokenDetectionController.ts       |   98.77 |    84.85 |     100 |   98.73 | 135
  TokenListController.ts            |   98.94 |    89.13 |     100 |   98.88 | 151
  TokenRatesController.ts           |   95.74 |    93.48 |   96.15 |   95.56 | 126,207,252,413
  TokensController.ts               |   97.18 |    94.71 |   90.91 |   97.18 | 299,534,538-541,641-651
  assetsUtil.ts                     |     100 |      100 |     100 |     100 |
  crypto-compare.ts                 |     100 |      100 |     100 |     100 |
  token-service.ts                  |     100 |       95 |     100 |     100 | 129
 src/Standards                      |   97.14 |    66.67 |     100 |   97.14 |
  ERC20Standard.ts                  |   97.14 |    66.67 |     100 |   97.14 | 82
 src/Standards/NftStandards/ERC1155 |   64.71 |    11.76 |   68.42 |      64 |
  ERC1155Standard.ts                |   64.71 |    11.76 |   68.42 |      64 | 44-45,111-126,167,172-182
 src/Standards/NftStandards/ERC721  |   98.44 |       85 |     100 |   98.36 |
  ERC721Standard.ts                 |   98.44 |       85 |     100 |   98.36 | 204
------------------------------------|---------|----------|---------|---------|---------------------------
Test Suites: 1 failed, 15 passed, 16 total
Tests:       3 failed, 294 passed, 297 total
Snapshots:   0 total
Time:        61.658 s
Ran all test suites.

The text was updated successfully, but these errors were encountered:

mcmire · 2023-08-17T20:26:55Z

With #1499 merged, is this still an issue?

legobeat · 2023-08-22T09:18:08Z

Somehow, yes:

 PASS   assets-controllers  src/TokenRatesController.test.ts (18.324 s)
 PASS   assets-controllers  src/TokensController.test.ts (19.512 s)
 PASS   assets-controllers  src/TokenListController.test.ts (21.299 s)
 PASS   assets-controllers  src/NftDetectionController.test.ts (22.612 s)
  ● Console

    console.error
      FetchError {
        message: 'request to https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset_contract/0xCE7ec4B2DfB30eB6c0BB5656D33aAd6BFb4001Fc failed, reason: Failed to fetch',
        type: 'system',
        errno: undefined,
        code: undefined
      }

      535 |       error === TIMEOUT_ERROR)
      536 |   ) {
    > 537 |     console.error(error);
          |             ^
      538 |   } else {
      539 |     throw error;
      540 |   }

      at logOrRethrowError (../controller-utils/src/util.ts:537:13)
      at ../controller-utils/src/util.ts:374:5
          at Generator.throw (<anonymous>)
      at rejected (../controller-utils/src/util.ts:6:65)

    console.error
      FetchError {
        message: 'request to https://proxy.metafi.codefi.network/opensea/v1/api/v1/asset_contract/0x0B0fa4fF58D28A88d63235bd0756EDca69e49e6d failed, reason: Failed to fetch',
        type: 'system',
        errno: undefined,
        code: undefined
      }

      535 |       error === TIMEOUT_ERROR)
      536 |   ) {
    > 537 |     console.error(error);
          |             ^
      538 |   } else {
      539 |     throw error;
      540 |   }

      at logOrRethrowError (../controller-utils/src/util.ts:537:13)
      at ../controller-utils/src/util.ts:374:5
          at Generator.throw (<anonymous>)
      at rejected (../controller-utils/src/util.ts:6:65)

mcmire · 2023-08-22T18:52:12Z

Ah, right.

I think there are two things going on here:

The tests are using "production" URLs, which makes it seem like the tests are actually hitting those URLs. This doesn't happen because network requests are being mocked.
Some tests mock requests to intentionally fail. For instance:

core/packages/assets-controllers/src/NftController.test.ts

Line 270 in f99e384

.replyWithError(new TypeError('Failed to fetch'))

. These failures are then logged in the utility function that actually makes the request:

core/packages/controller-utils/src/util.ts

Line 374 in f99e384

logOrRethrowError(e, errorCodesToCatch);

So I think these errors are expected, if a bit noisy.

legobeat · 2023-08-22T22:23:32Z

A couple of actual test failures, though. Full log attached.
assets-controller-test.log

mcmire · 2023-08-23T16:35:23Z

Hmm, I see. Thanks for posting that. I don't have any intuitions for why this is happening at the moment but can take a look when I get a chance.

desi · 2024-05-01T15:41:58Z

Further investigation is needed on this.

desi · 2024-05-01T15:42:35Z

Maybe this isn't happening anymore?

legobeat · 2024-05-01T17:59:35Z

Maybe this isn't happening anymore?

@desi It is not. Closing. Got any idea of when this was resolved?

desi added the team-wallet-framework label Apr 22, 2024

legobeat closed this as completed May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AssetsContractController: Unit tests fail on external endpoints #1213

AssetsContractController: Unit tests fail on external endpoints #1213

legobeat commented Apr 19, 2023 •

edited

Loading

mcmire commented Aug 17, 2023

legobeat commented Aug 22, 2023

mcmire commented Aug 22, 2023

legobeat commented Aug 22, 2023

mcmire commented Aug 23, 2023

desi commented May 1, 2024

desi commented May 1, 2024

legobeat commented May 1, 2024

AssetsContractController: Unit tests fail on external endpoints #1213

AssetsContractController: Unit tests fail on external endpoints #1213

Comments

legobeat commented Apr 19, 2023 • edited Loading

Description

Environment

Log

mcmire commented Aug 17, 2023

legobeat commented Aug 22, 2023

mcmire commented Aug 22, 2023

legobeat commented Aug 22, 2023

mcmire commented Aug 23, 2023

desi commented May 1, 2024

desi commented May 1, 2024

legobeat commented May 1, 2024

legobeat commented Apr 19, 2023 •

edited

Loading