Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug]: An alert warning is displayed to users about their first-time interaction with an account, even for accounts that are owned and contained within the wallet #28942

Closed
sleepytanya opened this issue Dec 4, 2024 · 1 comment · Fixed by #28990 · May be fixed by MetaMask/core#5024
Assignees
Labels
regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 release-12.10.0 Issue or pull request that will be included in release 12.10.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Currently, an alert You're interacting with this address for the first time. Make sure that it's correct before you continue. is displayed for accounts within the wallet.

Expected behavior

This alert should be reserved for external accounts.

Screenshots/Recordings

alert.mov
Screenshot 2024-12-04 at 16 20 45

Steps to reproduce

  1. Have several accounts in the wallet
  2. Send a transaction to one of your accounts

Error messages or log output

-

Detection stage

During release testing

Version

12.9.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 4, 2024
@bschorchit bschorchit added the release-blocker This bug is blocking the next release label Dec 4, 2024
@bschorchit
Copy link

Great catch, Tanya! I missed that scenario. @OGPoyraz can we skip this alert if the user is sending to one of its own accounts?

github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
## **Description**

Hide the first time interaction alert if the transaction `to` is an
internal account.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28990?quickstart=1)

## **Related issues**

Fixes: #28942 

## **Manual testing steps**

See issue.

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 6, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 6, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 6, 2024
matthewwalsh0 added a commit that referenced this issue Dec 6, 2024
Hide the first time interaction alert if the transaction `to` is an
internal account.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28990?quickstart=1)

Fixes: #28942

See issue.

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 release-12.10.0 Issue or pull request that will be included in release 12.10.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Archived in project
5 participants