-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(keyring-api)!: add scopes
field to KeyringAccount
#29195
Draft
ccharly
wants to merge
28
commits into
main
Choose a base branch
from
feat/keyring-account-scopes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+923
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/accounts-controller@20.0.0, npm/@metamask/eth-snap-keyring@5.0.1, npm/@metamask/keyring-controller@19.0.1 |
ccharly
force-pushed
the
feat/keyring-account-scopes
branch
from
December 13, 2024 11:36
d1cc825
to
81c5c8f
Compare
ccharly
changed the title
Feat/keyring account scopes
feat(keyring-api)!: add Dec 13, 2024
scopes
field to KeyringAccount
4 tasks
ccharly
force-pushed
the
feat/keyring-account-scopes
branch
from
December 13, 2024 17:12
ecb5bc1
to
3a72085
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing the new
scopes
added on theKeyringAccount
.Related issues
Requires this PR to be merged first:
@metamask/keyring-api
layout (split packages) #28861Related to:
scopes
field toKeyringAccount
accounts#101scopes
field toKeyringAccount
core#5066Manual testing steps
N/A
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist