Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Google's Material Design Lite #33

Open
Zodiase opened this issue Jul 8, 2015 · 11 comments
Open

Google's Material Design Lite #33

Zodiase opened this issue Jul 8, 2015 · 11 comments

Comments

@Zodiase
Copy link

Zodiase commented Jul 8, 2015

Hi, I'd like to create a Meteor package for Google's Material Design Lite.

@splendido
Copy link
Member

At the moment we're having some problem with autopublish.meteor.com, but we can continue to create official wrappers as long as we're keen to keep them up to date by hands...

the wrapper could look something like jspdf-core-wrapper.
Would you like me to create a repository for you to wrap to original repo?

@Zodiase
Copy link
Author

Zodiase commented Sep 2, 2015

Currently I'm using my own repo for publishing the package but what I do for updating the wrapped library is just manually building it and copy-pasting the build files into the repo replacing the old one. I'd love to have easier ways of doing this but the thing is I need to modify the source code of the wrapped library a little bit for its build files to work with Meteor. Any suggestions?

@splendido
Copy link
Member

Could those modifications be done in a stand-alone file?
In case the answer is yes, the latest wrapper approach used for jspdf-core-wrapper is still valid!

@Zodiase
Copy link
Author

Zodiase commented Sep 3, 2015

Unfortunately I have to modify the source code of the wrapped library and do a custom build for the fixes.

@Zodiase
Copy link
Author

Zodiase commented Sep 3, 2015

Now I'm thinking, perhaps I could do these things in my fork of the wrapped library and the package would just wrap my fork.

@splendido
Copy link
Member

Could you link to the changes you need? Some diff/comparison...

@Zodiase
Copy link
Author

Zodiase commented Sep 8, 2015

@Zodiase
Copy link
Author

Zodiase commented Sep 8, 2015

I forgot exactly what the error was without this line though...

@splendido
Copy link
Member

that seems something you could put also on a separate file on the wrapper repo...

@Zodiase
Copy link
Author

Zodiase commented Sep 23, 2015

This line has to be put inside that file almost exactly that location. Won't work before or after the file as the jspdf-core-wrapper example does. Also I don't understand what that repo is doing; meteor-pre.js defines a local window object that won't affect other files. Even if window was not available at the time of executing meteor-pre.js, it would still be unavailable for meteor-post.js as var is local to each file.

@splendido
Copy link
Member

perhaps we should get rid of the var keywork inside meteor-pre.js?
...the pre/post trick is usually used for those libraries expecting to have modules.exports or window defined: cheating a little bit the Meteor closure wrapped around package load usually permit to pick up the desired objects and eventually export them...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants