Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Parse DNS with provided array #75

Closed
NN--- opened this issue Jun 2, 2020 · 3 comments · Fixed by #169
Closed

Parse DNS with provided array #75

NN--- opened this issue Jun 2, 2020 · 3 comments · Fixed by #169
Milestone

Comments

@NN---
Copy link

NN--- commented Jun 2, 2020

Is there an option to parse a provided packet manually like DNS library can do ?

var r = Response.FromArray(array);

https://github.com/kapetan/dns/blob/master/DNS/Protocol/Response.cs#L29

@MichaCo
Copy link
Owner

MichaCo commented Jun 3, 2020

The parsing is currently internal. So, no, you cannot parse just data right now.

That being said, my plan was to add an extensibility API to version 2 sometime in the future.
I'm not really happy with how that API would look like with the current implementation, that's mostly why all that is internal right now which allows me to easily do changes without making breaking changes ^^

@NN---
Copy link
Author

NN--- commented Jun 4, 2020

It would be nice to have it exposed.

@MichaCo MichaCo added this to the Future milestone Jul 30, 2020
@MichaCo
Copy link
Owner

MichaCo commented Oct 23, 2022

I will make DnsDatagramReader public in version 1.7.
I'm not going to guarantee the same stability for that class as for the rest of the library though, so you might see breaking changes at some point. But I hope that helps.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants