Skip to content

Commit 2aa71d3

Browse files
committed
fix: Node version requirement >= 20.19
- Fixes ember-learn#1669 Caused by: ``` require() of ES Module .../.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported. Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules. ``` When using older node in consuming app.
1 parent 0f35016 commit 2aa71d3

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@
190190
}
191191
},
192192
"engines": {
193-
"node": ">= 18"
193+
"node": ">= 20.19"
194194
},
195195
"publishConfig": {
196196
"registry": "https://registry.npmjs.org"

test-apps/new-addon/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"webpack": "^5.96.1"
5353
},
5454
"engines": {
55-
"node": "16.* || >= 18"
55+
"node": ">= 20.19"
5656
},
5757
"ember": {
5858
"edition": "octane"

tests/dummy/app/templates/docs/usage.md

+10
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,16 @@ To use AddonDocs, your addon must have a `devDependency` of **Ember v2.8** or hi
77
Note that your addon can still support older versions of Ember – it's just that you won't be able to run your AddonDocs documentation site against those older versions. (This means you also cannot write acceptance/application tests against your docs sites on older versions of Ember.)
88

99

10+
### Node version
11+
12+
Due to [this issue](https://github.com/ember-learn/ember-cli-addon-docs/issues/1669) there is a requirement for consuming app to use [node>=20.19](https://nodejs.org/en/blog/release/v20.19.0/). Otherwise you might get following error during build:
13+
14+
```
15+
require() of ES Module .../.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported.
16+
Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.
17+
```
18+
19+
1020
## Installation
1121

1222
```sh

0 commit comments

Comments
 (0)