Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disabled telemetry and fixed tslint errors. #1375

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Disabled telemetry and fixed tslint errors. #1375

merged 2 commits into from
Mar 14, 2019

Conversation

tonyanziano
Copy link
Contributor

Was getting some tslint errors from d.ts files from sdk/ui-react now that they are being imported properly from #1368, so I fixed them.

I also cherry picked the disable telemetry commit from the v4.3 branch.

@coveralls
Copy link

coveralls commented Mar 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2230

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 55.108%
Totals Coverage Status
Change from base Build 2228: 0.1%
Covered Lines: 4875
Relevant Lines: 8316
💛 - Coveralls

@tonyanziano tonyanziano force-pushed the toanzian/disable-telem branch from df3a3f6 to 5c8621f Compare March 14, 2019 20:32
@tonyanziano tonyanziano merged commit 2cbf9c3 into master Mar 14, 2019
@tonyanziano tonyanziano deleted the toanzian/disable-telem branch March 14, 2019 20:50
@tonyanziano tonyanziano mentioned this pull request Mar 27, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyanziano @coveralls @a-b-r-o-w-n