Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixed a lot of LUIS inspector style issues. #1399

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Fixed a lot of LUIS inspector style issues. #1399

merged 2 commits into from
Apr 2, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Mar 28, 2019 •
edited
Loading

Fixes #1389, #1390, #1391, #1392

===

Summary of changes

  • Added spacing between "Recognizer Result" & "Raw Result" buttons
  • Removed   from entity viewer HTML and fixed formatting
  • Added correct text color theming to entity editor
  • Fixed inspector header text clipping
  • Added unauthorized log message when LUIS is not configured and trying to inspect a trace
  • Removed Unauthorized text from header when LUIS is not configured
  • Changed version header text to "Unknown" when LUIS is not configured

UI when LUIS is configured

Light
luis-configured

Dark
luis-configured-dark

High Contrast
luis-configured-hc

UI when LUIS is not configured

Light
luis-unconfigured

Dark
luis-unconfigured-dark

High Contrast
luis-unconfigured-hc

EDIT:

Added deep link to configure luis service:

image

@tonyanziano tonyanziano marked this pull request as ready for review March 29, 2019 18:59
@coveralls
Copy link

coveralls commented Mar 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2268

  • 11 of 27 (40.74%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 55.411%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/parts/log/logEntry.tsx 3 4 75.0%
packages/extensions/luis/client/src/Controls/Header/Header.tsx 0 1 0.0%
packages/extensions/luis/client/src/App.tsx 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
packages/extensions/luis/client/src/App.tsx 1 0.0%
Totals Coverage Status
Change from base Build 2262: 0.2%
Covered Lines: 4893
Relevant Lines: 8321
💛 - Coveralls

justinwilaby
justinwilaby suggested changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Themes specific to this extension should probably be located in the extension's project.

packages/app/client/src/ui/styles/themes/light.css Outdated Show resolved Hide resolved
@tonyanziano tonyanziano requested a review from justinwilaby April 1, 2019 21:47
justinwilaby
justinwilaby approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
LGTM

@tonyanziano tonyanziano merged commit 1c2b589 into master Apr 2, 2019
@tonyanziano tonyanziano deleted the toanzian/luis branch April 2, 2019 16:56
This was referenced Apr 2, 2019
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@justinwilaby justinwilaby justinwilaby approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LUIS inspector has bogus   in output
3 participants
@tonyanziano @coveralls @justinwilaby