Enabling padStart and padEnd by default on. #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianwjhalliday (or @Microsoft/chakra-es) have a look at this. |
|
Thank you! |
12 tasks
|
@ljharb thanks for mentioning that. bummer, I need to update few baselines (just ran es7 folder). |
Apart from enabling it, I found that spec for padStart/padEnd got changed where ,
8. If filler is the empty String, return S. (https://tc39.github.io/ecma262/#sec-string.prototype.padstart)
fixed that and updated the test.
test262 is fully passed for these two APIs.
|
Thanks for adding OOM scenario test. LGTM. |
chakrabot
pushed a commit
that referenced
this pull request
Jul 8, 2016
Merge pull request #1257 from akroshg:stringpad Apart from enabling it, I found that spec for padStart/padEnd got changed where , 8. If filler is the empty String, return S. (https://tc39.github.io/ecma262/#sec-string.prototype.padstart) fixed that and updated the test. test262 is fully passed for these two APIs.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from enabling it, I found that spec for padStart/padEnd got changed where ,
8. If filler is the empty String, return S. (https://tc39.github.io/ecma262/#sec-string.prototype.padstart)
fixed that and updated the test.
test262 is fully passed for these two APIs.