Support disabling interpreter thunks in JSRT #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHolman
approved these changes
Mar 9, 2018
boingoing
approved these changes
Mar 9, 2018
| @@ -341,6 +345,7 @@ namespace Js | |||
|
|
|||
| // Per script configurations | |||
| bool NoNative; | |||
| bool NoDynamicThunks; | |||
There was a problem hiding this comment.
I dislike this capitalization but ok.
liminzhu
reviewed
Mar 9, 2018
There was a problem hiding this comment.
I'd also add a note on JsRuntimeAttributeDisableNativeCodeGeneration that it does not stop all executable memory allocation and refer to this new flag. Other than that 
.
chakrabot
pushed a commit
that referenced
this pull request
Mar 10, 2018
…n JSRT Merge pull request #4797 from digitalinfinity:jsrt_thunk_master JsRuntimeAttributeDisableNativeCodeGeneration is not sufficient to disable all allocation of executable memory. Added a new attribute with explicitly this intent so that hosts running in locked down processes can embed ChakraCore
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsRuntimeAttributeDisableNativeCodeGeneration is not sufficient to disable all allocation of executable memory. Added a new attribute with explicitly this intent so that hosts running in locked down processes can embed ChakraCore