Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Referencing several Python extension Modules (*.pyd) does not work #810

Closed
kgrigo opened this issue Sep 4, 2015 · 2 comments
Closed

Referencing several Python extension Modules (*.pyd) does not work #810

kgrigo opened this issue Sep 4, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@kgrigo
Copy link

kgrigo commented Sep 4, 2015

We have a python Project and using PTVS 2.2 in Visual Studio Pro 2013 (Update 2).

While trying to add several references, Intellisence is working only for one. It seems after adding a new reference the *.idb files in AppData\Local\Python Tools\ReferencesDB\12.0 from the existing ones will be deleted.

I checkt the PTVS sources and found a bug in PythonTypeDataBase.cs -> FindDbFile. I could fix it by moving the part with check for correct file last modified date after the check for the correct module Name (see resulting code in ScreenShot). I tested it with a new build and it works fine in our Environment.

Did you already heared about this bug? Is there a possibility to get it fixed in your next released Version?

Best regards
Karo

changedcode

@zooba
Copy link
Member

zooba commented Sep 4, 2015

Nope, haven't heard about it. Good catch!

Can you send us a pull request with your change?

@zooba zooba added this to the 2.2.1 milestone Sep 4, 2015
@zooba
Copy link
Member

zooba commented Sep 4, 2015

(Oh, and looks like some indentation got moved around in your fix lines 317-18. We'll probably ask you to fix that in a PR, so maybe get it first :) )

zooba added a commit to zooba/PTVS that referenced this issue Oct 6, 2015
… not work

Compares last modified time against the file referenced by the row, rather than the newly added extension.
@zooba zooba self-assigned this Oct 6, 2015
zooba added a commit that referenced this issue Oct 6, 2015
Fixes #810 Referencing several Python extension modules does not work
@zooba zooba closed this as completed Oct 6, 2015
zooba added a commit to zooba/PTVS that referenced this issue Oct 6, 2015
… not work

Compares last modified time against the file referenced by the row, rather than the newly added extension.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants