Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Can't use "Enter" key to accept an IntelliSense item #756

Closed
rcjsuen opened this issue Mar 14, 2018 · 5 comments
Closed

Can't use "Enter" key to accept an IntelliSense item #756

rcjsuen opened this issue Mar 14, 2018 · 5 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
February 2018

Comments

@rcjsuen
Copy link
Contributor

rcjsuen commented Mar 14, 2018

monaco-editor version: 0.11 on the website I'm assuming
Browser: Version 64.0.3282.186 (Official Build) (64-bit)
OS: Windows 10
Steps or JS usage snippet reproducing the issue:

  1. Open the playground website.
  2. Hit Ctrl+Space
  3. Hit Enter
  4. A newline is inserted instead of the proposal.

I feel like it wasn't like this before...
@rcjsuen rcjsuen mentioned this issue Mar 14, 2018
Closed
@rebornix rebornix added the important Issue identified as high-priority label Mar 15, 2018
@alexdima alexdima modified the milestones: On Deck, February 2018 Mar 15, 2018
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Mar 15, 2018
@alexdima alexdima self-assigned this Mar 15, 2018
alexdima added a commit to microsoft/vscode that referenced this issue Mar 15, 2018
@alexdima
Fixes microsoft/monaco-editor#756
9aeff00
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 15, 2018

Thanks for fixing this so quickly, @alexandrudima. Will you be publishing an update to npm?

@alexdima
Copy link
Member

Yes, I just have a couple more things to do

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 15, 2018

Great to hear! Thank you and everyone else for the new release!

@alexdima
Copy link
Member

Just published 0.11.1

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Mar 15, 2018

Things look good in the Monaco Editor Playground. Thanks, Alexandru! :)

@rcjsuen rcjsuen mentioned this issue Mar 15, 2018
Merged
alexdima added a commit to microsoft/vscode that referenced this issue Mar 15, 2018
@alexdima
Fixes microsoft/monaco-editor#756
fb3aff9
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@rebornix @alexdima @rcjsuen