Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Go: add raw string literal syntax #10

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Conversation

nicot
Copy link
Contributor

@nicot nicot commented Sep 8, 2016

Go allows raw string literals using backquotes:
https://golang.org/ref/spec#String_literals

I'm not sure what the rules are on escaping inside raw string literals. This PR could be a starting point.

Thanks!

@msftclas
Copy link

msftclas commented Sep 8, 2016

Hi @nicot, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@alexdima alexdima self-assigned this Sep 8, 2016
@alexdima
Copy link
Member

@nicot Can you also please add some tests for this in https://github.com/Microsoft/monaco-languages/blob/master/test/go.test.ts

@nicot
Copy link
Contributor Author

nicot commented Sep 23, 2016

I've added a test for the raw string literal syntax.

Anything else I can do?

@alexdima alexdima merged commit ab254ce into microsoft:master Sep 26, 2016
@alexdima
Copy link
Member

Brilliant! Thank you for your contribution!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants