Add __generator helper to es6 source and populate jsnext:main #5
Conversation
frankwallis
changed the title
| @@ -27,5 +27,6 @@ | |||
| "url": "https://github.com/Microsoft/tslib.git" | |||
| }, | |||
| "main": "tslib.js", | |||
| "jsnext:main": "tslib.es6.js", | |||
There was a problem hiding this comment.
how is this supposed to work on node versions that does not support const? i do not think rollup rewrites const to var?
There was a problem hiding this comment.
that is a very good point, this issue seems to indicate that it should point to a file which is consumable by all engines for using es6 import/export statements.
In my scenario I actually do a second typescript transpilation to output the rollup bundle in system.register format and that removes the const keywords.
Shall I change the file to use export var?
There was a problem hiding this comment.
It seems to me that the ideal solution would be to have a single typescript source file which is then compiled to both targets, but I'm not sure how to handle the UMD / global wrapper stuff in the es5 file.
There was a problem hiding this comment.
I have updated the file to use var instead of const
|
There is also __extends helper missing in tslib.es6.js. See my issue microsoft/TypeScript#9980. Rollup also supports module field in package.json similar to jsnext:main. Is there any reason why "export const" but not "export var" is used? All other code is ES5. |
|
@dmitrage I have just added the __extends helper as well. Will wait for feedback on the const/var issue. |
|
Ember CLI also would benefit from adding the |
| @@ -27,5 +27,6 @@ | |||
| "url": "https://github.com/Microsoft/tslib.git" | |||
| }, | |||
| "main": "tslib.js", | |||
| "jsnext:main": "tslib.es6.js", | |||
There was a problem hiding this comment.
Maybe use module instead of jsnext:main to achieve same behavior, but less configuration since the module has been set to true as default in rollup-plugin-node-resolve.
# By Nathan Shively-Sanders (3) and others # Via GitHub * 'master' of https://github.com/Microsoft/tslib: Update version Fix microsoft#7: Update readme Update __rest emit to handle symbols Address PR comments. Add __rest helper Fix syntax error in __awaiter when running in ES3 # Conflicts: # tslib.es6.js
|
@mhegazy - I have refreshed this PR with the latest changes, can it now be merged? |
|
@mhegazy - thank you |
|
@mhegazy Thank you, btw could we anticipate that npm version includes this PR going to publish soon? |
This enables support for using the
importHelpersoption withmodule: 'es6'and then bundling the output with rollup, which automatically strips out any unused helper functions.