Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Coverage highlighting does not work when files are outside of $GOPATH #1122

Closed
arbourd opened this issue Jul 28, 2017 · 4 comments
Closed

Coverage highlighting does not work when files are outside of $GOPATH #1122

arbourd opened this issue Jul 28, 2017 · 4 comments

Comments

@arbourd
Copy link
Contributor

arbourd commented Jul 28, 2017

applyCoverage() does not work with files outside the $GOPATH.

coverageFiles paths come from go test, which returns non-$GOPATH paths like _/main.go
@arbourd arbourd mentioned this issue Jul 28, 2017
Merged
ramya-rao-a pushed a commit that referenced this issue Jul 28, 2017
@arbourd @ramya-rao-a
Add check for files outside $GOPATH (#1123)
b954085 
Fixes #1122
@andreis
Copy link

andreis commented Aug 20, 2017

This confused me a bit until I realised I was out of $GOPATH

@ramya-rao-a
Copy link
Contributor

The fix for this is now out in the latest update to the Go extension 0.6.64

@andreis
Copy link

andreis commented Sep 6, 2017

@ramya-rao-a just taking the chance to say you're doing an amazing job, I see you everywhere! 😄

@ramya-rao-a
Copy link
Contributor

:) thanks @andreis!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreis @arbourd @ramya-rao-a