Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

0.6.74 breaks envVars['Path'] #1508

Closed
malashin opened this issue Feb 10, 2018 · 2 comments
Closed

0.6.74 breaks envVars['Path'] #1508

malashin opened this issue Feb 10, 2018 · 2 comments

Comments

@malashin
Copy link

malashin commented Feb 10, 2018

After updating vscode-go to 0.6.74 I could not load gcc anymore, even though it was preset in the %PATH% and I was able to call it from builtin terminal.

img

Checking if that is the case on my other PC proved that it happens right after updating vscode-go to 0.6.74.

I was able to pin point the issue to this code 37570ab:

if (goroot && (<string>envVars['PATH'] || '').split(path.delimiter).indexOf(goroot) === -1) {
	envVars['PATH'] += (envVars['PATH'] ? path.delimiter : '') + goroot;
}

envVars['PATH'] does not actually exist (at least on Windows 7), envVars['Path'] does.

The code can't find the envVars['PATH'], but is still able to update envVars['Path'] with
"undefinedC:\tools\go". JavaScript is awesome...

@squaredice
Copy link

image
Same problem after update

@ramya-rao-a
Copy link
Contributor

Released an update (0.6.75) with the fix.
Thanks for reporting!

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 28, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants