Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add the output option for the delve #1564

Merged
merged 2 commits into from
Mar 18, 2018
Merged

Add the output option for the delve #1564

merged 2 commits into from
Mar 18, 2018

Conversation

trknhr
Copy link
Contributor

@trknhr trknhr commented Mar 7, 2018 •
edited
Loading

Hi

I added the output option for delve.
You would be able to use delve, even if there has been debug directory already.

Thank you

@ramya-rao-a
Copy link
Contributor

@1984weed I dont see the --output option when running dlv -h on version "1.0.0-rc.2". Is this available only on a newer version?

@trknhr trknhr force-pushed the Add-output-args-to-delve branch from 38c87ea to 1f14d37 Compare March 15, 2018 11:18
@trknhr
Copy link
Contributor Author

trknhr commented Mar 15, 2018

Sorry. It's only about debug mode.
https://github.com/derekparker/delve/blob/master/Documentation/usage/dlv_debug.md

@ramya-rao-a
Copy link
Contributor

You will need to add the output entry at https://github.com/Microsoft/vscode-go/blob/master/package.json#L319 as well, else you won't get a default or intellisense when editing the launch.json file

@msftclas
Copy link

msftclas commented Mar 16, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ramya-rao-a
Copy link
Contributor

@1984weed Can you sign the CLA?

@trknhr
Copy link
Contributor Author

trknhr commented Mar 18, 2018

Done !!

@ramya-rao-a ramya-rao-a merged commit 3a1067c into microsoft:master Mar 18, 2018
@ramya-rao-a
Copy link
Contributor

@1984weed This feature is now available in the latest update (0.6.78) to the Go extension. Thanks for the PR!

levrik
levrik reviewed Apr 9, 2018
View reviewed changes
package.json
},
"output": {
"type": "string",
"description": "Output path for the bynary of delve",
Copy link

@levrik levrik Apr 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo bynary -> binary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fixed in master

@ramya-rao-a ramya-rao-a mentioned this pull request Jun 29, 2019
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@levrik levrik levrik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trknhr @ramya-rao-a @msftclas @levrik