This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Make temporary build filename user specific to prevent conflict on systems with shared temp folders #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Aug 9, 2018
src/goBuild.ts
Outdated
| @@ -56,7 +56,7 @@ export function goBuild(fileUri: vscode.Uri, goConfig: vscode.WorkspaceConfigura | |||
| } | |||
|
|
|||
| const buildEnv = Object.assign({}, getToolsEnvVars()); | |||
| const tmpPath = path.normalize(path.join(os.tmpdir(), 'go-code-check')); | |||
| const tmpPath = path.normalize(path.join(os.tmpdir(), 'go-code-check.' + os.userInfo().username)); | |||
There was a problem hiding this comment.
Can we hash that name? There are cases where when trying to investigate an issue I request users to paste a screenshot of the output channel. User name is clearly PII 100% of the time and I want to stay clear of it.
Also, if we hash lets hash it once and re-use it.
There was a problem hiding this comment.
It doesn't really even need be a username, the filename could be anything providing it didn't cause a collision with another user.
I guess a hash based off username would be okay though, saves randomizing the filename and filling up /tmp.
I'll take another look at it 👍
|
|
rikkuness
changed the title
ramya-rao-a
approved these changes
Aug 13, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1829