Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix go tests variable can be array of completionitem or a completionlist #2016

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

wachino
Copy link
Contributor

@wachino wachino commented Oct 16, 2018

I've checked the travis pipeline is broken because of these changes

The items variable now can be of 2 different types: []CompletionItem or CompletionList.

Check here to check now the pipeline works fine

@msftclas
Copy link

msftclas commented Oct 16, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wachino!

Also, I see that this is your first contribution to vscode-go. Welcome & Thanks!
I hope that you have registered both for the Microsoft Hacktoberfest and the one from Digitalocean

Happy Coding!

@ramya-rao-a ramya-rao-a merged commit a9962eb into microsoft:master Oct 16, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants