#2063 only suggest exported member name at start of comment #2070
Conversation
There was a problem hiding this comment.
Thanks for the PR @kagof!
I see that this is your first contribution to this project, Welcome and Thanks!
We still want the suggestion to show up when we are in the first word in the comment.
For example, in the below case, when completion is triggered after He, we want the suggestion to show up
// He
func Hello() string {
return "hello"
}
|
Hi @ramya-rao-a , thanks for the clear feedback and the warm welcome! I've added another commit which allows the suggestion to show up in the first word. I've also rebased off of master to resolve a minor conflict. |
|
😈
Em Dom, 4 de nov de 2018 04:21, Karl Goffin <notifications@github.com>
escreveu:
… Hi @ramya-rao-a <https://github.com/ramya-rao-a> , thanks for the clear
feedback and the warm welcome! I've added another commit which allows the
suggestion to show up in the first word. I've also rebased off of master to
resolve a minor conflict.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2070 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Apf3hDoeP_em8TJxEgdrmh6j_tfwAHnkks5urodngaJpZM4YFvYo>
.
|
| suggestionItem = new vscode.CompletionItem(memberType[3], vscodeKindFromGoCodeClass(memberType[1], '')); | ||
| suggestionItem = new vscode.CompletionItem(memberType[3], vscodeKindFromGoCodeClass(memberType[1], '')); | ||
| } | ||
| return resolve(suggestionItem ? [suggestionItem] : []); |
There was a problem hiding this comment.
Any reason to move this return statement? With this change, when typing any text in the comments, we would end up calling gocode instead of exiting early
There was a problem hiding this comment.
Also can you update the existing test case to reflect the bug fix? See https://github.com/Microsoft/vscode-go/blob/0.7.0/test/go.test.ts#L1014
Resolves #2063 - only suggest the exported member name if the current comment has no content.