fix #2134 #2135
fix #2134 #2135
Conversation
There was a problem hiding this comment.
Thanks for the PR @oneslash!
Looks like this is your first PR in this project, Thanks & Welcome!
suggestions is never undefined as far as I know. It gets intialized to an empty array inside runGoCode
According to the call stack, the error is thrown at https://github.com/Microsoft/vscode-go/blob/0.7.0/src/goSuggest.ts#L163
It would be nice if we fix up getPackagePathFromLine to always return an array
|
I will fix it today |
|
@ramya-rao-a, could you check now? |
|
@ramya-rao-a, would be great if you can look into it soon :) |
There was a problem hiding this comment.
@oneslash Thanks for your patience. I was busy at work, so couldnt get to this PR sooner.
The current change looks good.
|
Congratulations on getting your first PR in this repository merged! |
I am trying to fix #2134