Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fixes #573 Update logic that determines in string position #586

Merged
merged 1 commit into from
Oct 31, 2016

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Oct 30, 2016

Fixes #573 by

  • Ignore escaped double quotes while counting double quotes in current line to determine if cursor is inside a string
  • If cursor is right outside a string, return no suggestions
  • Do not suggest unimproved pkg related suggestions, if cursor is inside string

A little history:

By default, vscode does not trigger auto-complete for special symbols like double quotes unless the extension implementing the autocomplete specifically says so.
The Go extension does ask for auto-complete for double quotes to support the scenario where you import packages like import ma should give options for packages starting with "ma"

@ramya-rao-a ramya-rao-a merged commit 5df5cd2 into microsoft:master Oct 31, 2016
@ramya-rao-a ramya-rao-a deleted the noSuggestInStrings branch April 9, 2017 17:05
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants