Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

VS Code as Git editor with --wait option doesn't let me edit interactive rebase file #42806

Closed
WouterDeKort opened this issue Feb 2, 2018 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@WouterDeKort
Copy link

  • VSCode Version: 1.19.3
  • OS Version: Windows 10 1703

Steps to Reproduce:

  1. git config --global core.editor "code --wait"
  2. git rebase HEAD~3 -i

Does this issue occur when all extensions are disabled?: Yes

I've setup VS Code as the global editor for Git on my Windows 10 pc like this:

git config --global core.editor "code --wait" If I now run something like git rebase HEAD~3 -i, after a long wait VS Code is launched and I see that it opens a tab named git-rebase-todo but before I can do (or see) anything the tab is closed and the command line thinks the rebase is finished by showing something like

Successfully rebased and updated refs/heads/Maintenance.

I see this behavior when using both PowerShell and the regular Console.

This is the content of my global git config file:

[user]
    name = Wouter de Kort
    email = ...
[winUpdater]
    recentlySeenVersion = 2.15.1.windows.2
[core]
    editor = code --wait
[diff]
    tool = default-difftool
[difftool "default-difftool"]
    cmd = code --wait --diff $LOCAL $REMOTE

I thought that adding the --wait flag was all I had to do. Any idea why Code is opening and closing the rebase file in one go?

@bpasero
Copy link
Member

bpasero commented Feb 2, 2018

@WouterDeKort does it help if you configure "workbench.editor.closeOnFileDelete": false?

@bpasero bpasero self-assigned this Feb 2, 2018
@bpasero bpasero added the info-needed Issue requires more information from poster label Feb 2, 2018
@WouterDeKort
Copy link
Author

@bpasero It's strange but I can't reproduce the issue. The rebase now opens Code for the actual rebase and for entering a new commit message. I have no idea what has changed over the weekend.

@bpasero bpasero closed this as completed Feb 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants